INTPYTHON-574 Use persistent connections by default #285
Conversation
|
IIRC so long as we're leveraging the same MongoClient, we are already maintaining an underlying connection pool. cc: @ShaneHarvey for confirmation. |
|
I don't think ASGI is a concern. See my comment in https://jira.mongodb.org/browse/INTPYTHON-574. Do we test that setup? |
ShaneHarvey
changed the title
|
I don't have much experience with ASGI/async, and I don't think the tests would catch a problem. Django has no tests for persistent connections which is why f5dbacb went undetected in initial development). If tests were added for ticket #33497, they would be expected failures on other backends. I'm going to have to investigate this in more detail to have any confidence that it works as expected which is why this PR is in draft status. |
|
I think this approach will be superseded by #290 (which is still in progress). |
After implementing this, I noticed a documentation note that persistent connections as implemented in Django aren't compatible with ASGI. https://code.djangoproject.com/ticket/33497#comment:51 I'm not sure if that's a concern for this library.
On the other hand, Django's documentation suggests to use connection pooling with ASGI, and I think we need to change this library to support that (i.e. not initialize a new
MongoClientin everyget_new_connection()call.